Protect against degenerate (zero area) mesh light faces (#2257)#21
Open
jlanz wants to merge 1 commit into
Open
Protect against degenerate (zero area) mesh light faces (#2257)#21jlanz wants to merge 1 commit into
jlanz wants to merge 1 commit into
Conversation
* Protect against degenerate (zero area) mesh light faces * Address copilot comments * Handle faces that have become degenerate through motion blur deformation * Return after degenerate face found --------- Co-authored-by: Ashley Lee <alee1@cobaltlane.gld.dreamworks.net> Signed-off-by: Jon Lanz <jon.lanz@dreamworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves OpenMoonRay/openmoonray#251
Fixed NaNs produced by degenerate MeshLight faces
Protect against degenerate (zero area) mesh light faces
Address copilot comments
Handle faces that have become degenerate through motion blur deformation
Return after degenerate face found
Co-authored-by: Ashley Lee alee1@cobaltlane.gld.dreamworks.net
Signed-off-by: Jon Lanz jon.lanz@dreamworks.com